Support for writing Ion Binary #39
Conversation
| * | ||
| * @param path path to create the directory. | ||
| * @return true if the directory was created, false otherwise. | ||
| */ | ||
| fun mkdir(path: String) = File(path).mkdirs() |
There was a problem hiding this comment.
nit: I would add the return type on the Kotlin signature as well, in case we alter the body in a way that alters the return type. Documents and possibly catches us from making an API change.
Since I am here. Are we planning to add the program that analyzes API changes for us on each version (todo or issue here would suffice)
There was a problem hiding this comment.
This is part of test code so we don't need to care much about breaking changes. Also since the SerDe not a general purpose library but a Hive plugin backward compatibility is not that important, it's more important to be compatible with Hive versions
| fun isClosed() = connection.isClosed | ||
|
|
||
| /** | ||
| * Drops all hive tables in the current database. | ||
| * | ||
| * **Note**: External tables don't their data destroyed. |
There was a problem hiding this comment.
don't have their data destroyed?
There was a problem hiding this comment.
external tables are akin to views. The data is actually managed by something else, e.g. HDFS, S3, so a drop table drops only the metadata but no data
serde/src/main/java/software/amazon/ionhiveserde/formats/IonInputFormat.java
Show resolved
Hide resolved
|
Merged manually |
Suport for writing Ion binary through the encoding SerDe property.
A lot of changes are due to normalizing the copyright notice after adding a checkstyle check to ensure that all files have it and it's all the same
#22
#4
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.