Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IntelliJ 2023.3 #59

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Support IntelliJ 2023.3 #59

merged 2 commits into from
Dec 19, 2023

Conversation

peddiashrith
Copy link
Contributor

@peddiashrith peddiashrith commented Dec 15, 2023

Notes

  1. adds GitHub actions changes
  2. add plugin info in the build.gradle.kts
  3. adds IC-233 source folder (copied from IC-232 folder)

Changes referenced from: #56

Testing

  • ./gradlew buildPlugin
  • ./gradlew verifyPlugin
  • Tested that generated zip file is working with IntelliJ 2023.3.1 version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

1. adds GitHub actions changes
2. add plugin info in the build.gradle.kts
3. adds IC-233 source folder
Copy link
Contributor

@desaikd desaikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @peddiashrith!
Some minor comments to address, otherwise the changes looks good. 🚢
I have verified locally with ./gradlew runIde as well to check formatting of an Ion file content.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/pr.yml Outdated Show resolved Hide resolved
@peddiashrith
Copy link
Contributor Author

peddiashrith commented Dec 18, 2023

Updated the pull request with requested changes

@popematt popematt merged commit 2dcf98c into amazon-ion:master Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants