Fixes a bug that caused the binary reader to prematurely assume EOF had been reached in an e-expression. #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad been reached in an e-expression.
jobarr-amzn
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
With the addition of e-expressions, this new code path is exercised. Before e-expressions, an optimization within the reader would have already filled the values in the container, if possible, causing a previous branch to be taken. I added a TODO to apply this optimization to e-expressions too, but that's out of scope for this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.