Remove pypy from benchmarking, and split requirements #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #377
Description of changes:
This PR removes pypy from the performance regression workflows. It also removes the benchmark cli tests, and benchmark spec tests from the main build & tests workflows so that we can eliminate other format libraries that may not support pypy from our ci checks, in order to continue validating pypy correctness.
requirements.txthas been split andrequirements_benchmark.txthas been populated with the dependencies needed only for benchmarking. When running the performance regression workflows, or local benchmarking efforts this new requirements file will need to be installed as well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.