-
Notifications
You must be signed in to change notification settings - Fork 37
Implement remaining tagless uints #993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nirosys
wants to merge
9
commits into
amazon-ion:main
Choose a base branch
from
nirosys:rgiliam/tagless_uints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and prepare for safe e-group writer
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
+ Coverage 78.28% 78.29% +0.01%
==========================================
Files 138 138
Lines 34036 34111 +75
Branches 34036 34111 +75
==========================================
+ Hits 26644 26707 +63
- Misses 5329 5331 +2
- Partials 2063 2073 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13 tasks
Build & Test fails due to clippy.. looks like a new rust release may have adjusted clippy lints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #943
Description of changes:
Prior to this PR (as of #991) supported tagless encoding was limited to
uint8
. This PR extends the unsigned int support to the remaininguint
types by implementinguint16
,uint32
anduint64
.CLI Testing
Below is an inspect of an encoding and usage of the following macro:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.