Merge pull request #4 from ambar/dev

feat: replace icons
ambar · Apr 4, 2024 · d574da1 · d574da1
2 parents cfee959 + 8be13e0
commit d574da1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 16 deletions.
diff --git a/.github/workflows/bundle-watch.yml b/.github/workflows/bundle-watch.yml
@@ -11,4 +11,4 @@ jobs:
       - uses: actions/setup-node@v4
       - uses: preactjs/compressed-size-action@v2
         with:
-          pattern: 'out/**/*.*'
+          pattern: '{images,out}/**/*.*'
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -31,7 +31,6 @@ jobs:
         run: |
           yarn jest --coverage
       # - name: report
-      #   uses: coverallsapp/github-action@v1.0.1
+      #   uses: coverallsapp/github-action@v2
       #   with:
       #     github-token: ${{ secrets.GITHUB_TOKEN }}
-      #     path-to-lcov: ./coverage/lcov.info
diff --git a/images/electron.svg b/images/electron.svg
diff --git a/images/node.svg b/images/node.svg
diff --git a/src/extension.ts b/src/extension.ts
@@ -299,6 +299,12 @@ function debounce<T extends AnyFunction<void>>(fn: T, wait: number) {
   } as T
 }
 
+// https://icon-sets.iconify.design/devicon/
+const iconMap: Record<Platform, string> = {
+  browser: 'images/electron.svg',
+  node: 'images/node.svg',
+}
+
 function setPanelTitleAndIcon(
   panel: vscode.WebviewPanel,
   document: vscode.TextDocument
@@ -308,15 +314,9 @@ function setPanelTitleAndIcon(
     `Preview` +
     (document ? ' ' + path.basename(document.uri.fsPath) : '') +
     ` in ${platformTitleMap[currentPlatform]}`
-  const iconMap = {
-    browser: 'electron',
-    node: 'node',
-  }
   panel.iconPath = vscode.Uri.joinPath(
     itsContext!.extensionUri,
-    `images/${
-      iconMap[currentPlatform as keyof typeof iconMap] ?? 'electron'
-    }.svg`
+    iconMap[currentPlatform]
   )
 }