-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): deb package on release #518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I can see from the log https://github.com/Ph0enixKM/amber-workflow-tests/actions/runs/11464290559/job/31900143129 the deb package was generated. I think that the issue is that I have to specify the file to upload because doesn't upload all the files in a specific folder. |
@Ph0enixKM can you try now? |
@Mte90 I'll finish fixing master and then I'll try it again |
Let's merge this fix (#535) and then I'll test this branch. |
After testing the new changes, it seems that it still does not work. I got no
|
I did that changes, automatically the file is created with the architecture where it is compiled. |
@@ -174,7 +174,10 @@ jobs: | |||
pattern: artifacts-* | |||
path: target/distrib/ | |||
merge-multiple: true | |||
|
|||
- name: Cargo Deb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't get it. i thought we still haven't discussed if it is our responsibility to maintain packages
i am making a code suggestion here so that this will be a discussion so it can be minimized when resolved
ref #294
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this at least be in a different repo in the organization? i'm pretty sure there is a million ways to get the tool to pull code from it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually projects release the package for the various distro, in a different repo I think that is the case when the project will grrow.
Right now I can be the debian maintainer, as the package it is just the binarry generated from rust in a dedicated compressed package, is not something like for Nix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a different repo I think that is the case when the project will grrow
normally i would agree to move it later, but files urls in releases are something people will use in scripts, so its not very good to modify or remove them. so it has to be moved there right away.
why even have it in the compiler repo? i don't think there is a valid reason for having it here rather than in a separate one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debian packages are easy to use and not that hard to maintain. I see the reason to support just the most popular distributions so that we can maintain a good experience of the installation process.
@Mte90 it seems that the CI still fails |
Define specific path to amber debian package so it's easier to debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked
Ref: #289
So I did an update to the toml file, the ci will use cargo deb to generate the package, tested locally and works.
I am not sure how the CI works, I think that I am putting the file in the right path but I am not sure if it is the right job.