Bugfix: Deactivate translation after build mail object

CHANGES.md

@@ -1,5 +1,8 @@
 # Changelog
 
+* *2.5.1* (2025-02-19)
+  * Fixed a bug, where translations were not deactivated after sending an email
+
 * *2.5.0* (2024-12-03)
   * Added connection param to `BaseEmailService` (Thx to @sk-rama)
 

django_pony_express/__init__.py

@@ -1,3 +1,3 @@
 """Class-based emails including a test suite for Django"""
 
-__version__ = "2.5.0"
+__version__ = "2.5.1"

django_pony_express/services/base.py

@@ -281,6 +281,9 @@ def _build_mail_object(self) -> EmailMultiAlternatives:
         # Add attachments (if available)
         msg = self._add_attachments(msg)
 
+        # Deactivate translation
+        translation.deactivate()
+
         # Return mail object
         return msg
 

tests/services/base/test_base_mail_service.py

@@ -306,6 +306,22 @@ def test_build_mail_object_translation_works(self):
         self.assertIn("vrijdag", msg_obj.body)
         self.assertIn("vrijdag", msg_obj.alternatives[0][0])
 
+    @freeze_time("2020-06-26")
+    @override_settings(LANGUAGE_CODE="de")
+    @mock.patch.object(BaseEmailService, "get_translation", return_value="nl-BE")
+    def test_build_mail_object_deactivates_language_afterwards(self, *args):
+        service = BaseEmailService(recipient_email_list="[email protected]")
+        service.template_name = "testapp/test_email.html"
+        msg_obj = service._build_mail_object()
+
+        # Assertions
+        # Assert, that email was rendered in nl-BE language
+        self.assertIn("vrijdag", msg_obj.body)
+        self.assertIn("vrijdag", msg_obj.alternatives[0][0])
+
+        # Assert, system language is back to "de"
+        self.assertEqual(settings.LANGUAGE_CODE, "de")
+
     def test_is_valid_positive_case(self):
         email = "[email protected]"
         subject = "Test email"