Add meson option for a static build #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwoloschin
force-pushed
the
static-build
branch
from
99c9fd2 to
757df84
Compare
amboar
requested changes
Nov 29, 2023
There was a problem hiding this comment.
So a commit message comment:
Can you add a mention of e.g. pipx install meson or pipx upgrade meson in the commit message for Bump meson_version to 1.1 to support meson.options? Just trying to help people out who might not realise that they're not constrained to their distro meson.
amboar
requested changes
Nov 29, 2023
amboar
requested changes
Nov 29, 2023
iwoloschin
commented
Nov 29, 2023
iwoloschin
force-pushed
the
static-build
branch
from
757df84 to
edd7c79
Compare
amboar
approved these changes
Nov 30, 2023
|
Ah, so I did just find this: https://mesonbuild.com/Release-notes-for-0-63-0.html#new-prefer_static-builtin-option Looks like we can drop the change to the libfdt |
amboar
force-pushed
the
static-build
branch
2 times, most recently
from
605255a to
c3d4eb7
Compare
Static builds of the culvert binary allow it to run anywhere without having to worry about packaging up libraries. This is useful if sending the binary to 3rd parties to run or when trying to support multiple Linux distributions that may have very old system libraries. Signed-off-by: Ian Woloschin <[email protected]> [AJ: Drop static kwarg for libfdt dependency, fix actions] Signed-off-by: Andrew Jeffery <[email protected]>
amboar
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case for a "run anywhere" build of
culvertso I wanted to build a statically linked binary. I've added a meson option to support this and left the default as dynamically linked.To test, delete your
builddirectory and run:meson setup build -Dstatic=true && meson compile -C buildAn important note, to set up
meson.optionsrequired bumping the meson_version to >= 1.1. I also fixed one new warning that came up after that change. I assume this is fine (it can easily be installed viapip3), but if it is not I can refactor this PR to usemeson_options.txt.