Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on python3-flake8-docstrings #513

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Dec 19, 2024

The flake8-docstrings package is a flake8 plugin wrapper around pydocstyle, which was deprecated and has now ceased development and maintenance.

See PyCQA/flake8-docstrings#68

This package has already been removed from Fedora and is not present in the current release, Fedora 41. It will likely not be packaged in EPEL 10 either.

Related:

@cottsay cottsay requested a review from clalancette December 19, 2024 01:58
@cottsay cottsay self-assigned this Dec 19, 2024
The flake8-docstrings package is a flake8 plugin wrapper around
pydocstyle, which was deprecated and has now ceased development and
maintenance.

Signed-off-by: Scott K Logan <[email protected]>
@cottsay cottsay force-pushed the cottsay/no-more-flake8-docstrings branch from 7c03c55 to f9a6fc2 Compare December 19, 2024 01:58
@cottsay
Copy link
Contributor Author

cottsay commented Dec 19, 2024

With --packages-up-to ament_lint_common:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

I'm fine with this, but we should probably also remove flake8-docstrings and pydocstyle from:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants