Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT Capabilities Part 1 - robot-log-visualizer #80
base: main
Are you sure you want to change the base?
RT Capabilities Part 1 - robot-log-visualizer #80
Changes from 64 commits
b46676b
6f1ec87
cfd0ede
f20c655
5b700c5
f8153d4
a716e59
ff33dc2
2de1dcd
6a3840d
aa331dd
3b86123
886a45b
a1a0799
e412bf4
e19c626
835a17f
0bf0525
872b364
36c9f3b
031c401
de5a54a
be3d77f
be1a667
82eb5e5
83dbebc
b117936
228e84f
4cd3a85
6d13f85
97d2a03
56c69ed
da33419
27eb858
0681e5a
1631469
8d96948
a8538d6
4b203ab
6c60288
32a05b7
3604f62
336db8e
ad228f1
e10efaa
bfce38b
3b7e98e
cadd9e0
0458de2
db95f5e
ac36876
82b5353
7b6f231
6056056
00c9011
f633d6d
0d2408c
4eacfa2
296ee38
d8b573b
ecdf600
059c6d6
a02f24e
621ce36
b98edec
221711a
49880bf
8cb0209
989426c
40f406b
fa4282f
0b033ba
f8b88fa
59953ef
ad96b95
76b3129
767c83c
2cc7277
f5b4a65
be77f98
5df2f88
5461cbe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GiulioRomualdi should we lazy load also yarp or we just need to lazy load blf?
fyi @nicktrem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine to have config files. However, I would keep blf deps relegated only for the real-time logging and use qt config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the remote should be set from the gui perhaps this can be the default value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not needed we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an autogenerated file and cannot be touched the correct approach here is to modify the UI file directly with qtcreator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in be77f98