Add vplay #841
Open
Add vplay #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick first answer: in my personal opinion, vplay would be a good name, in addition to the vtest we already have. |
|
@bturkus haven't had a chance to look at this very closely yet, but would this include the ability to go frame by frame? I think this sounds great! |
|
@bturkus - I also haven't had a chance to review closely, but at the surface I think this name and functionality are in-scope enough! My one thought is that when this gets merged we will have to remember to update the homebrew formula to install it to path when we do the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I’ve created this branch to introduce vplay.sh, a new script designed to offer playback of already digitized files with the mpv-based QC visualizations that we use during active digitization in vrecord. I wanted to include a few notes regarding this addition:
Out of Scope? If anyone feels this is out of scope for vrecord, I’d be happy to remove it. I understand if this doesn’t align with the project’s current direction.
Value of the Tool: I do think a tool like this could be valuable, given that vrecord already has the infrastructure for a variety of QC visualizations. While QCTools is excellent, there are situations where the responsiveness of MPV can be particularly useful for quick checks and visualizations.
Leveraging the QCView Lua Script: I wrote this with the intention of leveraging the existing qcview lua script. However, we could consider expanding this further, including using the passthrough configuration setting that a user has selected. What I’ve committed so far was significantly easier to implement but could serve as a base for further enhancements.
Naming Consideration: I know that the term 'vplay' has been discussed previously in relation to potential tools for testing and evaluating signal routes. If the name or this direction doesn’t align with those plans, I’d be more than happy to set this aside or adjust the approach as needed.
Looking forward to your feedback!