Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: First time developer setup #15

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

NiceGuyIT
Copy link
Contributor

While setting up the dev environment for the first time, I ran into some issues. This PR fixes .env.example to help future developers.

  1. The nginx container uses port 443 which is coming from DEV_PORT in tacticalrmm/.devcontainer/.env. These need to match.
  2. Vue was throwing a "DOMException: The operation is insecure" error because it's using ws://. Adding DOCKER_BUILD causes Vue to use wss://, solving the problem.

@wh1te909 wh1te909 requested a review from sadnub November 14, 2023 00:45
@wh1te909
Copy link
Member

I don't use docker for dev so as long as this still works for @sadnub fine by me

Copy link
Collaborator

@sadnub sadnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that .env file is actually used in production, so setting the DOCKER_BUILD to false in that file will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants