Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linkedin.py #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update linkedin.py #35

wants to merge 1 commit into from

Conversation

omarDans
Copy link

@omarDans omarDans commented Sep 9, 2024

I updated the init method of the Linkeding class

First of all, in the line 19 was an error because you forgot '()' so the comparison wasnt working at all:
if (platform.system == "Linux"):

Also, following the flow of the program, i think the previous check doesnt make anysense at all so i moved it to the else statement from the if at line 17:
if (len(linkedinEmail)>0):

Now if the user provided the gmail and password is going to try to authenticate that way, if the user didnt provide the credentials, it's going to correctly check if the script's is being executed from linux and then if the 'firefoxProfileRootDir' variable is defined, if it is not, it will through error and exit.

@aminblm
Copy link
Owner

aminblm commented Sep 12, 2024

Thank you @omarDans for your PR, I will review it and merge if all goes well.

Surely I left some unchecked errors for now but I will resume work on this sooner than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants