-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot fix/fix range stuck when to selected first #66
Open
KhaledAlramam
wants to merge
62
commits into
aminography:fixing_goto_issue
Choose a base branch
from
KhaledAlramam:hot-fix/fix_range_stuck_when_to_selected_first
base: fixing_goto_issue
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hot fix/fix range stuck when to selected first #66
KhaledAlramam
wants to merge
62
commits into
aminography:fixing_goto_issue
from
KhaledAlramam:hot-fix/fix_range_stuck_when_to_selected_first
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igits Improving arabic digits
Improving gradle configs Upgrading dependencies
…acceleration_issue Handling hardware acceleration issue
…o initial_from_date_for_range
…for_range Initial from date for range
…_memory_leak Resolving a minor memory leak
…i_below_17 Fixing ui symmetricity on api<17
Add feature of selecting end day automatically.
- Added startDate null check when "To" is clicked in PrimeDatePickerImpl.kt and RangeDaysSelectionBarView.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On range picker, If you select "To" before selecting StartDate the whole bottom sheet gets frozen
Temp fix:
Added nullability check on the Start Date before invoking "To" ClickListener