fix: Allow for lowercase token in ldap dn #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the validation regex to allow for lowercase LDIF field names in the dn (e.g. CN=foo vs cn=foo). Minio recently changed behaviour by using case sensitive ldap queries. This makes it necessary to specify the distinguished name for user/group policy attachments exactly in the same case as the server.
felladrin
approved these changes
May 22, 2024
There was a problem hiding this comment.
That's great! Pretty clear change!
Thanks and congratulations for your first pull request here, @fryshorts! 🎉
szinn
referenced
this pull request
in szinn/k8s-homelab
May 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | patch | `2.2.0` -> `2.2.1` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.2.1`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.2.1) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.2.0...v2.2.1) #### What's Changed - Fix: Allow for lowercase token in ldap dn by [@​fryshorts](https://togithub.com/fryshorts) in [https://github.com/aminueza/terraform-provider-minio/pull/563](https://togithub.com/aminueza/terraform-provider-minio/pull/563) #### New Contributors - [@​fryshorts](https://togithub.com/fryshorts) made their first contribution in [https://github.com/aminueza/terraform-provider-minio/pull/563](https://togithub.com/aminueza/terraform-provider-minio/pull/563) **Full Changelog**: aminueza/terraform-provider-minio@v2.2.0...v2.2.1 </details> <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzQuMyIsInVwZGF0ZWRJblZlciI6IjM3LjM3NC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19--> Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
kireque
referenced
this pull request
in kireque/home-ops
May 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [minio](https://registry.terraform.io/providers/aminueza/minio) ([source](https://togithub.com/aminueza/terraform-provider-minio)) | required_provider | patch | `2.2.0` -> `2.2.1` | --- ### Release Notes <details> <summary>aminueza/terraform-provider-minio (minio)</summary> ### [`v2.2.1`](https://togithub.com/aminueza/terraform-provider-minio/releases/tag/v2.2.1) [Compare Source](https://togithub.com/aminueza/terraform-provider-minio/compare/v2.2.0...v2.2.1) #### What's Changed - Fix: Allow for lowercase token in ldap dn by [@​fryshorts](https://togithub.com/fryshorts) in [https://github.com/aminueza/terraform-provider-minio/pull/563](https://togithub.com/aminueza/terraform-provider-minio/pull/563) #### New Contributors - [@​fryshorts](https://togithub.com/fryshorts) made their first contribution in [https://github.com/aminueza/terraform-provider-minio/pull/563](https://togithub.com/aminueza/terraform-provider-minio/pull/563) **Full Changelog**: aminueza/terraform-provider-minio@v2.2.0...v2.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzQuMyIsInVwZGF0ZWRJblZlciI6IjM3LjM3NC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS90ZXJyYWZvcm0iLCJ0eXBlL3BhdGNoIl19--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minio recently changed behaviour by using case sensitive ldap queries. This makes it necessary to specify the distinguished name for user/group policy attachments exactly in the same case as the server.
This merge request updates the validation regex to allow for lowercase LDIF field names in the dn (e.g. CN=foo vs cn=foo).
The relevant Minio MR: minio/minio#19358
As an alternative the regex could be made case insensitive with
(?i)^...but then also something likeCn=fooorcN=foowould be valid.