Implement SpawnMobPacket, Entity & Vehicle Movement Relevant Packets #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacholade
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again. :)
Had a bit of time this week to implement some new packets.
SpawnMobPacket
I used PrismarineJS/minecraft-data and created a little script to generate the ids of each entity for every major protocol version. It appears the id's for the entities in SpawnObjectPacket.EntityType may need updating, however will make another PR if this is the case. This being said, I'm not sure of the accuracy of Prismarine's data because it seems to be missing the id for wither_skeleton in some protocol_versions. Other than this I didn't notice any issues here. I've attached the json my script produced; however note that there are some duplicates and some entities changed name in some protocol versions so takes some looking around if used. https://hastebin.com/icuragepin.json
vs= protocol versionid= idiid= internalIdPositionLookAndDirection addition.
I added a new utility type for handling the additional
head_pitchattribute in the SpawnMobPacket. While this has benefits for the user I feel it may fairly obsolete and the user can simply access PositionAndLook as usual and the additional head_pitch attribute seperately.. It also overcomplicates this part of the packet to some extent. Feel free to suggest removing it from this PR.The rest of the packets are pretty straightforward... Hope there are no major concerns. Had a lot of fun doing this and learnt about the magic of descriptors (used in SpawnObject and SpawnMob) in doing so.