Refactor Cloudprovider routes so providerID is useable #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,7 +88,7 @@ func (c *Cloud) ListRoutes(clusterName string) ([]*cloudprovider.Route, error) { | |||
| } | |||
| instanceName := orEmpty(instance.PrivateDnsName) | |||
| routeName := clusterName + "-" + destinationCIDR | |||
| routes = append(routes, &cloudprovider.Route{Name: routeName, TargetInstance: instanceName, DestinationCIDR: destinationCIDR}) | |||
| routes = append(routes, &cloudprovider.Route{Name: routeName, TargetInstance: cloudprovider.Instance{Name: instanceName}, DestinationCIDR: destinationCIDR}) | |||
There was a problem hiding this comment.
Indentation issue here with spaces... (Needs "gofmt" or spaces to be convert to tabs)
|
Implementation, LGTM |
Reexport term.IsTerminal so downstream consumers (e.g. OpenShift) can use it.
Similar to %#v.
When using runtime.Object and runtime.RawExtension, passing runtime.Unknown to protobuf serializer should result in the raw message being serialized (since all normal protobuf objects are runtime.Unknown). Also, avoid setting a content-type when decoding a protobuf object except when the content appears to be proto.
Automatic merge from submit-queue Remove pod mutation for PVs with supplemental GIDs Continuation of kubernetes#27571 to bring the feature back without pod mutation
Automatic merge from submit-queue Fix watch cache filtering When serving watch events for a particular namespace, the watch cache filters out events from other namespaces by checking the etcd key of the event's object, and making sure it is prefixed with the root key for the namespace being watched. The prefix check does not ensure the match occurs on a path segment boundary, so a watch on namespace `test` is delivered watch events for namespace `test1`. This tightens the check to ensure the prefix match occurs on a path segment boundary.
Automatic merge from submit-queue Remove crufty blog post material that isn't actually an example.
Signed-off-by: Mike Brown <[email protected]>
HostPath volumes are not automatically provisioned unless we pass in `--enable-hostpath-provisioner` to the controller manager. This was not mentioned in the docs previously.
Signed-off-by: PingWang <[email protected]> Update genericapiserver.go Signed-off-by: PingWang <[email protected]>
…id-squash2 Revert "Remove pod mutation for PVs with supplemental GIDs"
Update external KubeletConfiguration type Add defaults for new KubeletConfiguration fields Modify some defaults to match upstream settings Add/rename some conversion functions Updated codegen Fixed typos Mike Danese caught that s.NodeLabels wasn't allocated, fix on line 118 of cmd/kubelet/app/options/options.go. Provide list of valid sources in comment for HostNetworkSources field
These tests can just use the empty string for the PodInfraContainerImage.
Move SystemReserved and KubeReserved into KubeletConfiguration struct Convert int64 to int32 for some external type fields so they match internal ones tLS* to tls* for JSON field names Fix dependency on removed options.AutoDetectCloudProvider Change floats in KubeletConfiguration API to ints
Automatic merge from submit-queue [garbage collector] add e2e test This PR also includes some changes to plumb controller-manager's `--enable_garbage_collector` from the environment variable. The e2e test will not be run by the core suite because it's marked `[Feature:GarbageCollector]`. The corresponding jenkins job configuration PR is kubernetes/test-infra#132.
Automatic merge from submit-queue Add RELEASE_INFRA_PUSH related code to support pushes from kubernetes/release. ref kubernetes#16529
…0714 Automatic merge from submit-queue Optimise the New function in genericapiserver.go It needn't the handlerContainer variable in the "New" function when deal s.HandlerContainer, I think, and it seems the codes more concise.
The more explicit regular expression for rejection makes a possibility of accessing pods (or any other resources) which contain "attach" or "exec" in their names via proxy API. It was not possible before. Also, the reference for "run" resource was removed, because it doesn't exist in any of k8s APIs currently. Fixes: kubernetes#21464
The current name, federation-apiserver-secret, is very similar to the other secret we have, federation-apiserver-secrets, that delivers somewhat similar data but in a different format. This is extremely confusing, particularly while debugging. This change should soothe the pain.
Automatic merge from submit-queue Unable to have optional message slice When making a message slice optional, we need to handle one more conditional case in the rewriter. @wojtek-t
Automatic merge from submit-queue Fix a typo in my Github username [madhusudancs].
…_pod Revert "Switched watches in tests require ResourceVersion to be passed"
Automatic merge from submit-queue Don't do string(int) This is causing kubernetes#29147 to fail the unit test, because the bug prints control character to the test log, and the grep at this [line](https://github.com/kubernetes/kubernetes/blob/master/hack/make-rules/test.sh#L190) returns `Binary file (standard input) matches` error. I don't know why this bug isn't caught before.
A comment in a pull-request will keep it open for another 90 days. Let's mention that in the documentation for people who can't add labels.
…erver-extensions-replicaset Automatic merge from submit-queue Add extensions/replicaset to federation-apiserver Add extensions/replicaset for federated scheduler (kubernetes#24038) as all k8s api objects were removed in kubernetes#23959 Please review only the very last one commit. kubernetes#19313 kubernetes#23653 @nikhiljindal @quinton-hoole, @deepak-vij, @XiaoningDing, @alfred-huangjian @mfanjie @huangyuqi @colhom
…oc-close-pr Automatic merge from submit-queue Mention that comments keep pull-requests open A comment in a pull-request will keep it open for another 90 days. Let's mention that in the documentation for people who can't add labels.
Automatic merge from submit-queue Log the time when checking deployment's pod availability kubernetes#26834 (comment)
…oller-v3 Automatic merge from submit-queue Certificate signing controller for TLS bootstrap (alpha) The controller handles generating and signing certificates when a CertificateSigningRequest has the "Approved" condition. Uses cfssl to support a wide set of possible keys and algorithms. Depends on PR kubernetes#25562, only the last two commits are relevant to this PR. cc @mikedanese []()
Automatic merge from submit-queue Ubuntu: Enable ssh compression when downloading binaries during cluster creation <!-- Checklist for submitting a Pull Request Please remove this comment block before submitting. 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 2. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 3. If you want this PR to automatically close an issue when it is merged, add `fixes #<issue number>` or `fixes #<issue number>, fixes #<issue number>` to close multiple issues (see: https://github.com/blog/1506-closing-issues-via-pull-requests). 4. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. --> resolves kubernetes#20971 by using the options provided by ssh. Native ssh compression has existed for years, and the server is free to disregard the setting, so this should be safe. With things like the kube binaries I see about a 2x speed increase. ``` λ time scp kubes-bin.tar 9.30.182.251:/mnt/build/kubin kubes-bin.tar 100% 344MB 10.7MB/s 00:32 real 0m32.284s user 0m1.679s sys 0m1.263s λ time scp -C kubes-bin.tar 9.30.182.251:/mnt/build/kubin kubes-bin.tar 100% 344MB 22.9MB/s 00:15 real 0m14.810s user 0m12.858s sys 0m0.994s λ ls -lah kubes-bin.tar -rw-r--r-- 1 mhb staff 344M Jun 2 15:29 kubes-bin.tar λ tar -tf kubes-bin.tar kubectl master/ master/etcd master/etcdctl master/flanneld master/kube-apiserver master/kube-controller-manager master/kube-scheduler node/ node/flanneld node/kube-proxy node/kubelet ```
…er-options Automatic merge from submit-queue Format apiserver options Trivial change, code formatting only: it was hard to read long lines, and my editor was really slow when scrolling through them.
…hosted_zones Automatic merge from submit-queue dnsprovider: Use route53 page functions to avoid truncated results The List<Type>Pages functions make it pretty easy to avoid result truncation; switch to using them
Automatic merge from submit-queue AWS: Added experimental option to skip zone check This pull request resolves kubernetes#28380. In the vast majority of cases, it is appropriate to validate the AWS region against a known set of regions. However, there is the edge case where this is undesirable as Kubernetes may be deployed in an AWS-like environment where the region is not one of the known regions. By adding the optional **DisableStrictZoneCheck true** to the **[Global]** section in the aws.conf file (e.g. /etc/aws/aws.conf) one can bypass the ragion validation.
Automatic merge from submit-queue Move ExtractPodBandwidthResources test into appropriate package Found during kubernetes#28511, this test is in the wrong package currently. cc @kubernetes/sig-network
…uler_tests_should_consider_unschedulable Automatic merge from submit-queue Revert "Scheduler predicates tests should consider unschedulable" Reverts kubernetes#28970 See kubernetes#28970 (comment) cc @pskrzyns @rmmh
Automatic merge from submit-queue Make "attach" and "exec" rejection in proxy more explicit ```release-note kubectl proxy changed to now allow urls to pods with "attach" or "exec" in the pod name ``` The more explicit regular expression for rejection makes a possibility of accessing pods (or any other resources) which contain "attach" or "exec" in their names via proxy API. It was not possible before. Also, the reference for "run" resource was removed, because it doesn't exist in any of k8s APIs currently. Fixes: kubernetes#21464
…g-secret-name Automatic merge from submit-queue Change the name of the secret that delivers federation kubeconfig. ```release-note Federation API server kubeconfig secret consumed by federation-controller-manager has a new name. If you are upgrading your Cluster Federation components from v1.3.x, please run this command to migrate the federation-apiserver-secret to federation-apiserver-kubeconfig serect; $ kubectl --namespace=federation get secret federation-apiserver-secret -o json | sed 's/federation-apiserver-secret/federation-apiserver-kubeconfig/g' | kubectl create -f - You might also want to delete the old secret using this command: $ kubectl delete secret --namespace=federation federation-apiserver-secret ``` The current name, federation-apiserver-secret, is very similar to the other secret we have, federation-apiserver-secrets, that delivers somewhat similar data but in a different format. This is extremely confusing, particularly while debugging. This change should soothe the pain. cc @kubernetes/sig-cluster-federation
Add and delete load balancer in front of apiserver.
…aster Revert "Add and delete load balancer in front of apiserver."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.