WireGuard rework for MacOS and Windows #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update MacOS service
pokamest
requested changes
Sep 14, 2023
client/daemon/daemonlocalserver.cpp
Outdated
| @@ -76,12 +76,12 @@ QString DaemonLocalServer::daemonPath() const { | |||
| } | |||
|
|
|||
| if (dir.exists("amneziavpn")) { | |||
| logger.debug() << "/var/run/amneziavpn seems to be usable"; | |||
| logger.debug() << "/var/run/amnezia seems to be usable"; | |||
There was a problem hiding this comment.
check if (dir.exists("amneziavpn")) - but message about "/var/run/amnezia" - looks like it's typo?
client/daemon/daemonlocalserver.cpp
Outdated
| return VAR_PATH; | ||
| } | ||
|
|
||
| if (!dir.mkdir("amneziavpn")) { | ||
| logger.warning() << "Failed to create /var/run/amneziavpn"; |
| @@ -14,10 +13,14 @@ | |||
| #include <QJsonValue> | |||
| #include <QStandardPaths> | |||
|
|
|||
| //#include "errorhandler.h" | |||
There was a problem hiding this comment.
please cleanup unnecessary commented lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new background WG service for vpn tunnel.