Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit @options with instace method amoeba_dup #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thinhbui311
Copy link

  • Be able to get @options in child associations

@coveralls
Copy link

coveralls commented Jan 7, 2022

Coverage Status

Coverage decreased (-2.6%) to 92.657% when pulling 990d65c on thinhbui311:options-inheritance into 99d0775 on amoeba-rb:master.

@jrmhaig
Copy link
Collaborator

jrmhaig commented Jan 8, 2022

Hi @thinhbui311. Thanks for the PR.

I am not the creator of this gem, only the last person to be added as an owner, so I am not completely familiar with how it works (yet). Could you please explain, possibly with an example, of what the @options hash is used for and why it needs to be inherited. I cannot find it used anywhere and I suspect it was added as a catch-all that was never used.

@aaricpittman
Copy link

I'm interested in this feature as well.

@jrmhaig some of the macros already reference @options, e.g.

copy_of_obj = old_obj.amoeba_dup(@options)
I think the value of which is nil because I cannot find where it is getting set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants