Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PBX Network did_full hack #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkania
Copy link

@rkania rkania commented Sep 7, 2015

did_full is now set to P-Called-Party-ID (first two digits removed)

did_full is now set to P-Called-Party-ID (first two digits removed)
@rkania
Copy link
Author

rkania commented Sep 7, 2015

This is for "old" PBX Network contracts, which transmit the account number as ${EXTEN}. So we need to extract the correct information out of P-Called-Party-ID.

In the next days I will verify how this behaves with "new" PBX Network contracts (VOIP Trunk 2.0).

@rkania
Copy link
Author

rkania commented Sep 17, 2015

Hi! Yes, I agree. That's why I called it "hack" ;-).
I will think about a better implementation, you idea is a good start.

FYI: I think PBX Network changed their trunk product again (not Teles NGN hw, afaik). I was in contact with them the last days, due to some issues when using GS 3.2 with their VoIP Trunk 2.0. Now everything is working very well; but requires another GS 3.2 patch (increase the field length of gateway username to 50).
AND: the "did_full hack" isn't required anymore.

@Reiner030
Copy link

a nice... yes the [email protected] username was already there for longer time ^^ ...
the NGN usecase needs some patched headers for sucessfull forwarding calls with the correct number / when you want to be anonymous... I must see if I can find in my history / one possible ... yes, I have luck:

/opt/gemeinschaft/etc/asterisk/e.ael

>           // HACK ClipNoScreening
>           // cid_host is "officepro.flex-o.de"
>           SIPAddHeader(P-Preferred-Identity: ${CALLERID(name)} <sip:${r_${r}_cid}@${r_${r}_cid_host}>);
>           // HACK ClipNoScreening

and

>           // HACK Flex-O CLIR
>                         if (!${REGEX("flexode" ${r_${r}_dial:-12})} ) {
>               Set(CALLERID(num-pres)=prohib_passed_screen);
>               Set(CALLERID(name-pres)=prohib_passed_screen);
>           }
>                         // /HACK Flex-O CLIR

... but this should be separate patch requests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants