Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distininguish between lead_preprocessed_data and historical_preprocessed_data #234

Closed
Tims777 opened this issue Feb 3, 2024 · 0 comments · Fixed by #236
Closed

Distininguish between lead_preprocessed_data and historical_preprocessed_data #234

Tims777 opened this issue Feb 3, 2024 · 0 comments · Fixed by #236
Assignees
Labels
refactoring Improvement to code structure that leaves functionalities untouched
Milestone

Comments

@Tims777
Copy link
Contributor

Tims777 commented Feb 3, 2024

There is an issue in naming between lead_preprocessed_data and historical_preprocessed_data. We must distinguish between both. Currently the code only names the output as preprocessed_data without any distinction.

Acceptance Criteria

  1. "data preprocessing" step can be applied on both lead and historical data but will use a different output file name for each case
  2. Training uses only historical data
  3. Merchant Size Prediction should use lead_preprocessed_data for prediction

All the previous should work with both DB types: Local and S3

@Tims777 Tims777 added this to the Demo Day milestone Feb 3, 2024
@Tims777 Tims777 added the refactoring Improvement to code structure that leaves functionalities untouched label Feb 3, 2024
@Tims777 Tims777 linked a pull request Feb 6, 2024 that will close this issue
@Tims777 Tims777 removed a link to a pull request Feb 6, 2024
@Tims777 Tims777 linked a pull request Feb 6, 2024 that will close this issue
@Tims777 Tims777 closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improvement to code structure that leaves functionalities untouched
Projects
Status: Feature Archive
Development

Successfully merging a pull request may close this issue.

3 participants