Prediction runs both locally and via S3 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Sheta <[email protected]>
Signed-off-by: Ahmed Sheta <[email protected]>
Signed-off-by: Ahmed Sheta <[email protected]>
… Merchant Size Prediction Signed-off-by: Ahmed Sheta <[email protected]>
ultiwinter
changed the title
Tims777
reviewed
Feb 4, 2024
There was a problem hiding this comment.
Looks good so far, I will try it out tomorrow. Once that is done, I will approve the PR👍
One thing I noticed is that you use if S3_bool: / else: quite often. I think it would be cleaner to have that logic in the database abstraction layer instead. However, due to the time constraints and because it will not impact our ability to demo the software in any way, I would suggest to just leave it like that.
Signed-off-by: Ahmed Sheta <[email protected]>
luccalb
reviewed
Feb 5, 2024
luccalb
reviewed
Feb 5, 2024
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
|
I've added some minor changes to improve the stability of running the merchant size prediciton locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Merchant Size Prediction works both locally and via S3
Note: Due to shortage of time, please feel free to modify right away!