Automatic creation of simplified reports issue #81 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ur-tech
commented
Dec 5, 2023
ur-tech
commented
- Adjusted to different inputs
- Customization of reports possible, by defining a format
- New report folder with pdf for each specified lead
- Gitignore for created pdf's
Co-authored-by: Ahmed Sheta <[email protected]> Signed-off-by: Fabian Utech <[email protected]>
There was a problem hiding this comment.
Maybe a more generall question for understanding this code:
- does this support the functionality to provide one/multiple leads and generating reports from them directly?
- If so: how can I test this?
- If not: was that in the scope of the task or is that part of another task?
src/report.py
Outdated
| # Input search string (either specific leads or a whole file) | ||
| # Output: pd.series of a lead from leads_enriched.csv | ||
| try: | ||
| df = pd.read_csv("src/data/leads_enriched.csv", delimiter=",") |
There was a problem hiding this comment.
Can this be extended to also allow S3 usage? Perhaps this can be combined with the new DAL to retrieve a certain lead regardless of storage location
There was a problem hiding this comment.
I will adjust it to the new documentation theme and S3 architecture in the next sprint. Then it should be also clear, how it works / how to test it
There was a problem hiding this comment.
It is a deprecated now. It is not compatible with the new version of the main.py .
If needed can be executed simply by using python reports.py
Closed
Signed-off-by: Berkay Bozkurt <[email protected]>
Signed-off-by: Berkay Bozkurt <[email protected]>
Signed-off-by: Berkay Bozkurt <[email protected]>
Signed-off-by: Berkay Bozkurt <[email protected]>
Signed-off-by: Berkay Bozkurt <[email protected]>
* Added folder for jupyter notebooks and dependencies Signed-off-by: Lucca Baumgärtner <[email protected]> * Adjusted notebook for local use Signed-off-by: Lucca Baumgärtner <[email protected]> --------- Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Nico Hambauer <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
upload sprint-10 imp-squared-backlog.jpg
upload sprint-10 imp-squared-backlog.jpg
* Added folder for jupyter notebooks and dependencies Signed-off-by: Lucca Baumgärtner <[email protected]> * Adjusted notebook for local use Signed-off-by: Lucca Baumgärtner <[email protected]> --------- Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Nico Hambauer <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Sprint 10 Release
…roj/amos2023ws06-sales-lead-qualifier into feature/154-train-ML-model
…roj/amos2023ws06-sales-lead-qualifier into feature/154-train-ML-model
Feature/154 train ml model
Signed-off-by: Berkay Bozkurt <[email protected]>
…and pipenv installed packages Signed-off-by: Ahmed Sheta <[email protected]>
Signed-off-by: Ahmed Sheta <[email protected]>
Signed-off-by: Ahmed Sheta <[email protected]>
… Merchant Size Prediction Signed-off-by: Ahmed Sheta <[email protected]>
Signed-off-by: Ahmed Sheta <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Prediction runs both locally and via S3
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
…alifier into dev Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
…lifier into feature/229-more-test-cases Signed-off-by: Felix Zailskas <[email protected]>
Feature/229 more test cases
* fix minor error in regionalatlas step + moved scrape address step to deprecated + added new bdc config Signed-off-by: Lucca Baumgärtner <[email protected]> * undo change to input filename Signed-off-by: Lucca Baumgärtner <[email protected]> * Adjust gpt caching error logging Signed-off-by: Lucca Baumgärtner <[email protected]> * change input file location back to original Signed-off-by: Lucca Baumgärtner <[email protected]> * Add explanation for deprecation of scrape_addresses.py Signed-off-by: Lucca Baumgärtner <[email protected]> * Adjust error logging for review analysis Signed-off-by: Lucca Baumgärtner <[email protected]> * remove deprecated steps from tests Signed-off-by: Lucca Baumgärtner <[email protected]> --------- Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Ahmed Sheta <[email protected]>
removed the redundant S3 question prompt from data preprocessing
…e analysis Signed-off-by: Fabian Utech <[email protected]>
Add the SBOM generator and feature analysis
Signed-off-by: Fabian Utech <[email protected]>
Signed-off-by: Fabian Utech <[email protected]>
Co-authored-by: Ahmed Sheta <[email protected]> Signed-off-by: Fabian Utech <[email protected]>
Signed-off-by: Fabian Utech <[email protected]>
…proj/amos2023ws06-sales-lead-qualifier into feature/81-simplify-reports
Signed-off-by: Fabian Utech <[email protected]>
…proj/amos2023ws06-sales-lead-qualifier into feature/81-simplify-reports
|
Superseeded by #245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.