Bugfix/235 all steps bdc errors #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecated + added new bdc config Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
|
All apparent errors were addressed but it might still need extensive testing after merging, especially the location of enriched and preprocessed files. |
Signed-off-by: Lucca Baumgärtner <[email protected]>
felix-zailskas
requested changes
Feb 5, 2024
Tims777
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Do we need force_refresh on all the earlier steps if we only want to run RegionalAtlas?
There was a problem hiding this comment.
Depends if you expect that there can be newer data found than what you have locally. I don't expect the addresses to change much and the regionalatlas data is local anyway so it cant change.
There was a problem hiding this comment.
In any case, it's ensured that the data is present, it's just not refreshed :)
Signed-off-by: Lucca Baumgärtner <[email protected]>
Added docs and fixed conflict. |
felix-zailskas
approved these changes
Feb 6, 2024
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regionalatlas.pyscrape_address.pyto deprecatedCloses Repair BDC pipeline runs with forceRefresh=False #235