Feature/229 more test cases #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
…lifier into feature/229-more-test-cases Signed-off-by: Felix Zailskas <[email protected]>
Closed
|
Target branch should be dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test cases for:
The test coverage is now at 45%. This is due to newly added code in the last week. I added tests for all modules that were easily testable with straightforward unit tests. The effort, complexity and time required to test the other modules seems to exceed the scope of this sprint, hence I will not implement them. The desired coverage of 60% is not realistic.