Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/9 initial cicd pipeline #38

Merged
merged 16 commits into from
Oct 28, 2023
Merged

Feature/9 initial cicd pipeline #38

merged 16 commits into from
Oct 28, 2023

Conversation

luccalb
Copy link
Collaborator

@luccalb luccalb commented Oct 28, 2023

Create an initial pipeline with following structure:

  • License Check
    • setup python & install deps
    • export all direct and transient dependencies to txt file
    • check the txt file and fail on copyleft licenses
  • Lint & Test
    • setup python & install deps
    • lint using flake8
    • test using pytest

Closes #9

ur-tech and others added 15 commits October 27, 2023 16:34
@ur-tech
Added overview of BDC features for issue #17
7f4f0fc 
Overview over possible features we want to add to our Base Data Collector (BDC)
@luccalb
Create python-app.yml
1150fe6
@luccalb
create a test dummy for checking the pipeline
c8417be 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
Merge remote-tracking branch 'origin/feature/9-initial-cicd-pipeline'…
b830fed 
… into feature/9-initial-cicd-pipeline
@luccalb
run unit tests in the virtual env
e3af52d 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
add pytest to dev deps, automate license checking
eb99f8c 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
add pytest to dev deps, automate license checking
eff72d9 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
add pytest to dev deps, automate license checking
11f25bf 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
add pytest to dev deps, automate license checking
307e204 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
try to fix license checking, by changing python version
5c8c362 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
try to fix license checking, by changing license checker version
a88d669 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
try to fix license checking, by adding a dep
3414c6e 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
try to fix license checking, by adding a dep
e448d59 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
move license checking to own job
5fb5215 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb
use latest versions for actions
b74a6af 
Signed-off-by: Lucca Baumgärtner <[email protected]>
@luccalb luccalb added the infrastructure Tasks regarding the IT infrastructure label Oct 28, 2023
@luccalb luccalb self-assigned this Oct 28, 2023
@luccalb luccalb linked an issue Oct 28, 2023 that may be closed by this pull request
Setup CI / CD pipelines #9
Closed
felix-zailskas
felix-zailskas requested changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@felix-zailskas felix-zailskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a small comment towards the python versions.

.github/workflows/python-app.yml Outdated Show resolved Hide resolved
felix-zailskas
felix-zailskas approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@felix-zailskas felix-zailskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@luccalb luccalb merged commit 301e06f into dev Oct 28, 2023
4 checks passed
@luccalb luccalb deleted the feature/9-initial-cicd-pipeline branch October 28, 2023 15:51
luccalb added a commit that referenced this pull request Nov 4, 2023
@luccalb
Feature/9 initial cicd pipeline (#38)
e11f271 
---------

Signed-off-by: Lucca Baumgärtner <[email protected]>
rbbozkurt pushed a commit that referenced this pull request Nov 5, 2023
@luccalb @rbbozkurt
Feature/9 initial cicd pipeline (#38)
dda15b4 
---------

Signed-off-by: Lucca Baumgärtner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-zailskas felix-zailskas felix-zailskas approved these changes

Assignees

@luccalb luccalb

Labels
infrastructure Tasks regarding the IT infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup CI / CD pipelines
3 participants
@luccalb @felix-zailskas @ur-tech