Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the EVP skeleton class. Issue #22 #39

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

felix-zailskas
Copy link
Contributor

Implemented a skeleton class for the EVP. This includes the following:

  • The EstimatedValuePredictor class. This class now uses just LinearRegression to predict from dummy values. The function estimate_value can be used to get the value of a lead given its ID.
  • The database package is a placeholder for the database we will use in the end. For now, it includes a singleton instance of a DatabaseDummy object. This object uses the dummy_leads.json file as its data. The dummies in that file are in accordance to the data field definition.
  • The database package also contains the models.py and parsers.py files. Here models.py contains models that we might retrieve or store in the database. The Lead class is especially important here. I used the pydantic library for automatic field validation.

@felix-zailskas felix-zailskas added the feature Specific feature, part of a certain module label Nov 2, 2023
@felix-zailskas felix-zailskas self-assigned this Nov 2, 2023
@felix-zailskas felix-zailskas linked an issue Nov 2, 2023 that may be closed by this pull request
@luccalb
Copy link
Collaborator

luccalb commented Nov 3, 2023

Looks good, maybe you could add a tests/test_evp.py file that checks the evp outputs and will run during testing stage.

@felix-zailskas
Copy link
Contributor Author

Looks good, maybe you could add a tests/test_evp.py file that checks the evp outputs and will run during testing stage.

Adjusted.

* add pipfile.lock, make pipenv install verbose

Signed-off-by: Lucca Baumgärtner <[email protected]>

* enable caching pipenv deps in pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

* check if moving the test file fixes it

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add __init__.py to tests folder

Signed-off-by: Lucca Baumgärtner <[email protected]>

* refactor test

Signed-off-by: Lucca Baumgärtner <[email protected]>

* refactor test

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

---------

Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Felix Zailskas <[email protected]>
@luccalb luccalb self-requested a review November 3, 2023 15:16
Copy link
Collaborator

@luccalb luccalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@felix-zailskas felix-zailskas merged commit 8107616 into dev Nov 3, 2023
4 checks passed
@felix-zailskas felix-zailskas deleted the feature/evp-skeleton branch November 3, 2023 15:18
luccalb pushed a commit that referenced this pull request Nov 4, 2023
Implemented the EVP skeleton class. Issue #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Specific feature, part of a certain module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement EVP skeleton
2 participants