generated from amosproj/amos202Xss0Y-projname
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented the EVP skeleton class. Issue #22 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed some dummy data for example purposes. #22 Signed-off-by: Felix Zailskas <[email protected]>
…lifier into feature/evp-skeleton
…lidation to Lead object Signed-off-by: Felix Zailskas <[email protected]>
Closed
Looks good, maybe you could add a |
Signed-off-by: Felix Zailskas <[email protected]>
…n each execution with dummy data. Signed-off-by: Felix Zailskas <[email protected]>
Adjusted. |
* add pipfile.lock, make pipenv install verbose Signed-off-by: Lucca Baumgärtner <[email protected]> * enable caching pipenv deps in pipeline Signed-off-by: Lucca Baumgärtner <[email protected]> * check if moving the test file fixes it Signed-off-by: Lucca Baumgärtner <[email protected]> * add __init__.py to tests folder Signed-off-by: Lucca Baumgärtner <[email protected]> * refactor test Signed-off-by: Lucca Baumgärtner <[email protected]> * refactor test Signed-off-by: Lucca Baumgärtner <[email protected]> * add all dev deps to Pipfile Signed-off-by: Lucca Baumgärtner <[email protected]> * add all dev deps to Pipfile Signed-off-by: Lucca Baumgärtner <[email protected]> * add all dev deps to Pipfile Signed-off-by: Lucca Baumgärtner <[email protected]> * minor changes to pipeline Signed-off-by: Lucca Baumgärtner <[email protected]> * minor changes to pipeline Signed-off-by: Lucca Baumgärtner <[email protected]> --------- Signed-off-by: Lucca Baumgärtner <[email protected]>
luccalb
reviewed
Nov 3, 2023
Signed-off-by: Felix Zailskas <[email protected]>
luccalb
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
luccalb
pushed a commit
that referenced
this pull request
Nov 4, 2023
Implemented the EVP skeleton class. Issue #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a skeleton class for the EVP. This includes the following: