Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/evp skeleton fix pipeline #40

Merged
merged 11 commits into from
Nov 3, 2023

Conversation

luccalb
Copy link
Collaborator

@luccalb luccalb commented Nov 3, 2023

  • Added Pipefile.lock to VCS
  • Added all missing dev dependencies to Pipfile and changed to pipenv install --dev in pipeline
  • removed fetch_depth: 0 from build step, as it seems unnecessary to fetch all of the repositories history for this step

Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Signed-off-by: Lucca Baumgärtner <[email protected]>
Copy link
Contributor

@felix-zailskas felix-zailskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix thank you!

@luccalb luccalb merged commit 0191d5c into feature/evp-skeleton Nov 3, 2023
4 checks passed
ruchita-nathani pushed a commit that referenced this pull request Nov 5, 2023
* add pipfile.lock, make pipenv install verbose

Signed-off-by: Lucca Baumgärtner <[email protected]>

* enable caching pipenv deps in pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

* check if moving the test file fixes it

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add __init__.py to tests folder

Signed-off-by: Lucca Baumgärtner <[email protected]>

* refactor test

Signed-off-by: Lucca Baumgärtner <[email protected]>

* refactor test

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

---------

Signed-off-by: Lucca Baumgärtner <[email protected]>
rbbozkurt pushed a commit that referenced this pull request Nov 5, 2023
* add pipfile.lock, make pipenv install verbose

Signed-off-by: Lucca Baumgärtner <[email protected]>

* enable caching pipenv deps in pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

* check if moving the test file fixes it

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add __init__.py to tests folder

Signed-off-by: Lucca Baumgärtner <[email protected]>

* refactor test

Signed-off-by: Lucca Baumgärtner <[email protected]>

* refactor test

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* add all dev deps to Pipfile

Signed-off-by: Lucca Baumgärtner <[email protected]>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

* minor changes to pipeline

Signed-off-by: Lucca Baumgärtner <[email protected]>

---------

Signed-off-by: Lucca Baumgärtner <[email protected]>
@Tims777 Tims777 linked an issue Nov 15, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement EVP skeleton
2 participants