feat: Function implementation: manage and update pump state (XD-65) #198
Conversation
KonsumGandalf
force-pushed
the
feat/xd-65
branch
from
42e6f09
to
e6934b8
Compare
libs/cases/frontend/view/src/lib/components/create-case/create-case.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
I have to say I couldn't really review the changes properly because there are so many files changed (because of the rebasing) and multiple commits. But from what I saw you added the 3 states which is nice and your pump-analyse.utils.ts and the test for it look really fancy and good.
I am sorry about the failing tests on unchanged files. I did not know anything about that. I think since it is not just that one test we might need an issue for that to fix all failing tests on develop.
On the files changed list there are a lot of things different to the current state of develop (f.e. my #191 is not there) so that still needs to be brought back. Maybe consider creating a new branch and putting your changes there (I did the same for #82 and with intellij it was actually not a lot of effort. I just clicked "show diff with working tree" on the old branch and put all files I wanted from there over)
|
I created an issue for the failing tests #200 and already started working on it |
Co-authored-by: Patrick Schmidt <[email protected]> Co-authored-by: Ingo Sternberg <[email protected]> Signed-off-by: Maximilian Krug <[email protected]>
Signed-off-by: Ingo Sternberg <[email protected]>
Signed-off-by: Ingo Sternberg <[email protected]> #82
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
KonsumGandalf
force-pushed
the
feat/xd-65
branch
from
fb9ebe0
to
6b187a6
Compare
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Signed-off-by: David Schmidt <[email protected]>
Closes: #65