Feat/xd 193 #199
Merged
Feat/xd 193 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libs/cases/frontend/view/src/lib/components/case-browse/case-browse.component.ts
Outdated
Show resolved
Hide resolved
libs/cases/frontend/view/src/lib/components/create-case/create-case.component.ts
Outdated
Show resolved
Hide resolved
libs/cases/frontend/view/src/lib/components/open-cases/open-cases.component.ts
Outdated
Show resolved
Hide resolved
libs/facilities/backend/facilities/src/lib/controller/facilities.controller.spec.ts
Outdated
Show resolved
Hide resolved
IngoSternberg
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Nice PR. I found some small things and have 2 questions. Also I have to say I don't really know that much about the backend.
I still have 2 general questions:
Is there now an attribute "amount of cases" or something for every facility or does that belong to another issue?
In the frontend cases stuff there are a lot of lines changed but I did not really see much of a difference. Did you do any bigger changes or only some formatting there?
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
Co-authored-by: Patrick Schmidt <[email protected]> Signed-off-by: Jonas <[email protected]>
Co-authored-by: Patrick Schmidt <[email protected]> Signed-off-by: Jonas <[email protected]>
Signed-off-by: Jonas <[email protected]>
|
Since you asked if the frontend works I tested it and it seemed ok. The state management from the current develop branch is not yet here but since it doesn't affect the changed files it should be ok. |
IngoSternberg
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect cases to facility