Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/xd-153 - Label Components properly in Create Case Page with CSS #203

Closed
wants to merge 5 commits into from
Closed

Feat/xd-153 - Label Components properly in Create Case Page with CSS #203

wants to merge 5 commits into from

Conversation

Sabo2k
Copy link
Contributor

@Sabo2k Sabo2k commented Jun 24, 2024 •
edited
Loading

Refactored Create Case Page and improved labels of the form

@Sabo2k Sabo2k changed the title Feat/xd-153 Feat/xd-153 - Add filter options for the cases page Jun 24, 2024
@IngoSternberg
Copy link
Contributor

The #153 issue is not "add filter options for the cases page" but something else. Did you pick the wrong name?

@Sabo2k
Copy link
Contributor Author

Sabo2k commented Jun 24, 2024

The #153 issue is not "add filter options for the cases page" but something else. Did you pick the wrong name?

Yes, you're right. My bad. Thanks for letting me know 👍

@Sabo2k Sabo2k changed the title Feat/xd-153 - Add filter options for the cases page Feat/xd-153 - Label Components properly in Create Case Page with CSS #153 Jun 26, 2024
@Sabo2k Sabo2k marked this pull request as ready for review June 26, 2024 08:18
@Sabo2k Sabo2k changed the title Feat/xd-153 - Label Components properly in Create Case Page with CSS #153 Feat/xd-153 - Label Components properly in Create Case Page with CSS Jun 26, 2024
@IngoSternberg
Copy link
Contributor

IngoSternberg commented Jun 26, 2024 •
edited
Loading

I have to say in my opinion these HTML comments like <!-- Date Selection- -> are not very useful, because most of the time HTML code is self explanatory (and we don't have them anywhere else). But since they might be helpful in some cases it would be ok for me if you keep them.

IngoSternberg
IngoSternberg requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@IngoSternberg IngoSternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I found was the hide-list-header. Apart from that it looks good.

@IngoSternberg IngoSternberg mentioned this pull request Jul 9, 2024
Merged
@Sabo2k Sabo2k marked this pull request as draft July 11, 2024 19:30
@IngoSternberg
Copy link
Contributor

IngoSternberg commented Jul 11, 2024 •
edited
Loading

There are so many files changed eventhough you only actually changed one in a meaningful way. Sometimes this happens eventhough there is no difference to develop, but here there is a difference. Since you only changed one file I suggest that you copy that somewhere then completely reset this branch or create a new branch of develop. Then paste that file on the reseted/new branch and merge that

@Sabo2k Sabo2k closed this Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IngoSternberg IngoSternberg IngoSternberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sabo2k @IngoSternberg