-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add frontend tests (XD-101) #251
Conversation
libs/facilities/frontend/view/src/lib/directives/back-button.directive.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look at it for longer than 10 minutes tomorrow, but please adjust the authentication service again, because like this it does not work anymore
I know it does not belong in this PR but since you did the metrics chart #215 could you maybe fix another bug related to the metrics chart? The reason is the item[key]! in the metrics chart signal They can be null so the ! does not work and the component crashes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find much more
- Nice that you added enums on the case-browse.component.ts
- Change to move date-Dropdown accessor to a Folder accessors is good
- not sure what you changed on the create-case.component.ts but it seems like you removed some unused code so if you checked if it still looks like before it is good
Its fixed thotugh feat/xd-216 |
I didnt change anything I just linted the Create Case Component. |
ef13f18
to
06eb2eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the changes. Should be good now
Closes: #101