Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add frontend tests (XD-101) #251

Merged
merged 12 commits into from
Jul 14, 2024
Merged

test: Add frontend tests (XD-101) #251

merged 12 commits into from
Jul 14, 2024

Conversation

KonsumGandalf
Copy link
Collaborator

Closes: #101

@KonsumGandalf KonsumGandalf linked an issue Jul 11, 2024 that may be closed by this pull request
12 tasks
Copy link
Contributor

@IngoSternberg IngoSternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look at it for longer than 10 minutes tomorrow, but please adjust the authentication service again, because like this it does not work anymore

@IngoSternberg
Copy link
Contributor

IngoSternberg commented Jul 11, 2024

I know it does not belong in this PR but since you did the metrics chart #215 could you maybe fix another bug related to the metrics chart?
Sometimes it just looks like this (even for the same facility when you reload multiple times this can happen)
grafik

The reason is the item[key]! in the metrics chart signal
grafik

They can be null so the ! does not work and the component crashes:
grafik
grafik

Copy link
Contributor

@IngoSternberg IngoSternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find much more

  • Nice that you added enums on the case-browse.component.ts
  • Change to move date-Dropdown accessor to a Folder accessors is good
  • not sure what you changed on the create-case.component.ts but it seems like you removed some unused code so if you checked if it still looks like before it is good

@KonsumGandalf
Copy link
Collaborator Author

I know it does not belong in this PR but since you did the metrics chart #215 could you maybe fix another bug related to the metrics chart? Sometimes it just looks like this (even for the same facility when you reload multiple times this can happen) grafik

The reason is the item[key]! in the metrics chart signal grafik

They can be null so the ! does not work and the component crashes: grafik grafik

Its fixed thotugh feat/xd-216

@KonsumGandalf
Copy link
Collaborator Author

I could not find much more

  • Nice that you added enums on the case-browse.component.ts
  • Change to move date-Dropdown accessor to a Folder accessors is good
  • not sure what you changed on the create-case.component.ts but it seems like you removed some unused code so if you checked if it still looks like before it is good

I didnt change anything I just linted the Create Case Component.

Copy link
Contributor

@IngoSternberg IngoSternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the changes. Should be good now

@KonsumGandalf KonsumGandalf merged commit a53f8d5 into develop Jul 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for frontend
2 participants