generated from amosproj/amos202Xss0Y-projname
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/xd 243 #260
Merged
Merged
Refactor/xd 243 #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
…face.ts Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
…e the components Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
12 tasks
… page Signed-off-by: Ingo Sternberg <[email protected]> #243
…e those edge cases never happen Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]>
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Signed-off-by: Ingo Sternberg <[email protected]> #243
Hydraneut
reviewed
Jul 16, 2024
Signed-off-by: Ingo Sternberg <[email protected]> #243
Hydraneut
approved these changes
Jul 16, 2024
Hydraneut
approved these changes
Jul 16, 2024
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for the #243 issue. A summary of what I did:
After (still not perfect as the ix-tile can never change its size)
2024-07-20T07:28:40.417Z
) had to end withT00:00:00.000Z$
so at midnight with 0 minutes/seconds. This rule does not exist in the backend/anywhere else and did not allow editing my generated cases since my seeding script had randomly generated timestimeseries.service.spec.ts
because there were small differences in the query times leading to a comparison failure.it was because it subtracts the current time difference in the
timeseries.service.spec.ts
:I fixed it by adding a tolerance to the time in one position and just ignoring the time in another position
17. ran
nx run-many -t lint
to make sure all files pass linting for the final release