Polishing search PopUp #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persistent input in search popup. Enhanced search suggestion relevancy. Signed-off-by: Celine Pöhl <[email protected]>
Corgam
reviewed
May 28, 2024
There was a problem hiding this comment.
Still some bugs present:
- If you search something and click one of the locations then the pop-up closes but the search is not cleared if you want to search once more
- If you search something and close the pop-up by clicking outside of it, then the search results still are visible (just sometimes, maybe it will be nice to clear the cache after exiting the popup)
And if possible I would like to see the favourites always on top + the recent history implemented (and if present, hiding whenever a new search is started)
Sorry, I can't recreate the bugs you found. Can you show them to me in the meeting tomorrow?
Yes but then this should have been a ticket |
Corgam
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked on these features: