Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend polishing - part 1 #224

Merged
merged 10 commits into from
Jun 2, 2024
Merged

Frontend polishing - part 1 #224

merged 10 commits into from
Jun 2, 2024

Conversation

Corgam
Copy link
Collaborator

@Corgam Corgam commented May 31, 2024

Added:

  • Empty map option
  • Made dropdown menu for tab options
  • Info popup for tabs
  • Styled map buttons

Corgam added 10 commits May 29, 2024 16:55
@Corgam
Added empty map to the datasets list
7e0a6e2 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Worked on the improved dataset tabs
e2af742 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed localhost
c63ecba 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed event propagation issue
0039752 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Disabled click animation on tabs
8f76040 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Worked on improving info panel for datasets
9669355 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Disabled alert for no dataset connection
ca3062c 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Moved the child component to seperate file
3821541 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Made the map button style the same
baae0a8 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Moved tooltips for buttons to right
ea8727f 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam Corgam requested review from Lucas-Nan and CelineMP May 31, 2024 19:02
@Corgam Corgam added the frontend Issues related to the user interface of a web application label May 31, 2024
Lucas-Nan
Lucas-Nan previously approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@Lucas-Nan Lucas-Nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works. I dont like the satellite view icon that much because it suggests more than 2 layers which is not currently planned - but as it is easily adjustable we can leave it for now (and for the pos)

@Lucas-Nan Lucas-Nan dismissed their stale review June 2, 2024 05:11

its for a merge into main

@Corgam Corgam changed the base branch from main to sprint-release June 2, 2024 09:01
CelineMP
CelineMP approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@CelineMP CelineMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Corgam Corgam merged commit 10e5a05 into sprint-release Jun 2, 2024
2 checks passed
This was referenced Jun 4, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CelineMP CelineMP CelineMP approved these changes

@Lucas-Nan Lucas-Nan Lucas-Nan left review comments

Assignees
No one assigned
Labels
frontend Issues related to the user interface of a web application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Corgam @CelineMP @Lucas-Nan