New Search Bar + Fly To works #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Celine Pöhl <[email protected]>
Signed-off-by: Celine Pöhl <[email protected]>
CelineMP
added
the
frontend
Signed-off-by: Celine Pöhl <[email protected]>
Signed-off-by: Celine Pöhl <[email protected]>
Signed-off-by: Celine Pöhl <[email protected]>
Lucas-Nan
previously approved these changes
Jun 3, 2024
Signed-off-by: Celine Pöhl <[email protected]>
Lucas-Nan
previously approved these changes
Jun 3, 2024
Signed-off-by: Celine Pöhl <[email protected]>
|
Added some commits that make flying to a location from the search possible now |
Lucas-Nan
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New expandable Search Bar on top left on map.
Favorites always fixed on top.
All results can be added to favorites now.
In MapOptions I kept the old button that triggers the SearchPopUp in comments so we can quickly change if we prefer the old design.
I didn't integrate the latitude-longitude search as I want to discuss it first. My opinion is to leave it like that because users copy paste coordinates anyway and don't need a seperate input mode.
I was not sure about the folder structure. SearchBar.tsx is now in the PopUp folder, has to be changed eventually.