Tab change bug, DataView show/hide, bold titles

[CelineMP]

Fixed this bug: #212

There were two problems:

• Clicking on "…" bubbled up to parent and always led to tab change
• Tab Option Menu used the opened tab's id. So I made a new tab ID that is set when "…" is clicked

[Corgam]

I am so happy that you managed to fix it! I just have one comment that the Info popup option is not working correctly, and maybe if you can disable the black border when the tab is focussed that would be great ( when you click ... and click out of the popup somewhere on the screen)

EDIT: And I found another thing that if you click in the red region the tab does not change

[CelineMP]

Oh no true, the info is broken!
Yes the border looks bad. It shouldn't even be focusable, it should just change to the tab.

EDIT: Yes exactly. Wherever you click (besides the three dots), it should change.

[CelineMP]

@Corgam I fixed the three mentioned things now:

• Info PopUp bug
• You can click everywhere on the Tab to change, not only the text
• Removed focus outline

[CelineMP]

Now this PR also includes:

• Functionality to hide data view panel #247
• The titles in the data view sections should be bold text #248

The functionality is now there. But where exactly the hide/show button should be can be discussed next sprint. For now I put it next to the "new tab" button.

[Lucas-Nan]

bugs seem to fixed as far as i can see | button is temporary there but i think it should still be closer to the plus btn - so just not filled and maybe rounded corners

this looks too out of place for me

[Corgam]

bugs seem to fixed as far as i can see | button is temporary there but i think it should still be closer to the plus btn - so just not filled and maybe rounded corners this looks too out of place for me

I agree, it would be nice to not create more work/tasks for the next sprints, just implement the final styling from the start :)
I would suggest using CaretDoubleRight icon (It would look better, but I think still the dataview needs a little cleanup with icons, there would be too many, maybe delete the pin icon next to the coordinates)

[Lucas-Nan]

emils proposed variant doesnt support hiding the whole thing so nicely

[CelineMP]

@Lucas-Nan

I implemented your feedback. But I personally prefer a different background color.

@Corgam

The problem is: when you put the icon into the DataView, where is it when the DataView is hidden?

[Corgam]

@Lucas-Nan

I implemented your feedback. But I personally prefer a different background color.

@Corgam

The problem is: when you put the icon into the DataView, where is it when the DataView is hidden?

I like it how it is right now after the changes, maybe just use the double arrows and I would be really happy haha

[CelineMP]

I like it how it is right now after the changes, maybe just use the double arrows and I would be really happy haha

Done!