Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend - Polishing up before release #364

Merged
merged 33 commits into from
Jul 7, 2024
Merged

Frontend - Polishing up before release #364

merged 33 commits into from
Jul 7, 2024

Conversation

Corgam
Copy link
Collaborator

@Corgam Corgam commented Jul 6, 2024 •
edited
Loading

Corgam added 27 commits July 2, 2024 20:16
@Corgam
Implemented simple 3D window
e6fdfc8 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Added leaflet map render
a90c1ca 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed map not loading and camera
674a403 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Further work on the controlls
de76e8a 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Worked on the controls
96ecd27 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
The proper map is rendered instead
29ab70f 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Merge branch 'sprint-release' into dev-eb
7709ab3
@Corgam
Fixed popup for for marker on double click
a89f8b7 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Switching to new tab on add
ba7939c 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Reload button on tab switch
e57d7e7 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Started working on the polygon location data
b088652 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Worked on drawing polygons
c31430b 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed not changing isDrawing
657108a 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Removing old polygon when drawing a new one
1742ff1 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Disable draw polygon tooltips
a76058c 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Finished the styling of the polygon
7bba4d4 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed display of coordinates in dataview
e49e4b4 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Created a selection type
720a4c6 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Added mapcontext reference for polygon event
d2a5beb 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed location endpoint calls
f3a71e6 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Added working selections with search bar
7416af6 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Added ability to store marker names
505b816 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed drawing of searched addresses + cleanup of last search
59ca878 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed location endpoint body
55330d7 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Cleanup
cfc092d 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Implemented the open as a map functionality
3f678e1 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Removed temp location values
c035d6c 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam Corgam marked this pull request as draft July 6, 2024 14:20
@Corgam
Removed 3D
dda4db7 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed styling issue with polygon drawing
3772bca 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Uninstalled Three.js
eed1cc9 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam Corgam requested review from Lucas-Nan and CelineMP July 6, 2024 15:00
@Corgam Corgam marked this pull request as ready for review July 6, 2024 15:00
@Corgam Corgam added the frontend Issues related to the user interface of a web application label Jul 6, 2024
@Corgam
Copy link
Collaborator Author

Corgam commented Jul 6, 2024 •
edited
Loading

To be fixed (discussed with Lucas and Oli):

  • No charging stations at the load
  • Search bar text should disappear
  • Slight transparency inside the selection
  • Smaller gray overlay

EDIT: Fixed!

Corgam and others added 3 commits July 6, 2024 19:03
@Corgam
Small fixes
e37254b 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Fixed data not loading at the start
3a16353 
Signed-off-by: Emil Balitzki <[email protected]>
@Lucas-Nan
fixed/added multipolygon handling
38f6f55 
Signed-off-by: Lucas-Nan <[email protected]>
CelineMP
CelineMP approved these changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@CelineMP CelineMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! We might only have to change the polygon and the polygon selection to blue (PO said that)

@CelineMP CelineMP merged commit 0357b4b into sprint-release Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CelineMP CelineMP CelineMP approved these changes

@Lucas-Nan Lucas-Nan Awaiting requested review from Lucas-Nan

Assignees
No one assigned
Labels
frontend Issues related to the user interface of a web application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Corgam @CelineMP @Lucas-Nan