Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed data sources to Erlangen + small FE fixes #401

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Changed data sources to Erlangen + small FE fixes #401

merged 4 commits into from
Jul 13, 2024

Conversation

Corgam
Copy link
Collaborator

@Corgam Corgam commented Jul 13, 2024

Done:

  • Small FE fixes
    • Sub-data rows styling
    • No Individual Data section when it is empty
  • Changed data sources to be focused on a single location - Erlangen
    • Hause footprints, actual use

@Corgam
Fixed styling issues
9ec8bb7 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam
Changed data sources
25465f1 
Signed-off-by: Emil Balitzki <[email protected]>
@Corgam Corgam added the backend Issues related to the data, logic, or communication of the application label Jul 13, 2024
@Corgam Corgam self-assigned this Jul 13, 2024
@Corgam Corgam changed the base branch from main to sprint-release July 13, 2024 12:01
@Corgam Corgam changed the title Changed data source to Erlangen + small FE fixes Changed data sources to Erlangen + small FE fixes Jul 13, 2024
Lucas-Nan
Lucas-Nan previously requested changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Lucas-Nan Lucas-Nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDatasetList is requested the whole time

@Corgam
Last fixes
06f4161 
Signed-off-by: Emil Balitzki <[email protected]>
@Lucas-Nan Lucas-Nan self-requested a review July 13, 2024 14:40
Lucas-Nan
Lucas-Nan approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Lucas-Nan Lucas-Nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datasources all valid for erlangen (small datapipeline error for actual use - already in sprint release), cleaned up well

@Lucas-Nan Lucas-Nan merged commit 205fcf7 into sprint-release Jul 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucas-Nan Lucas-Nan Lucas-Nan approved these changes

@Superschnizel Superschnizel Awaiting requested review from Superschnizel

@nicolasbandel nicolasbandel Awaiting requested review from nicolasbandel

Assignees

@Corgam Corgam

Labels
backend Issues related to the data, logic, or communication of the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Corgam @Lucas-Nan