Ignore deletion exception on Windows

amphp · Dec 8, 2024 · 9f06c5f · 9f06c5f
1 parent 70df517
commit 9f06c5f
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/FileMutex.php b/src/FileMutex.php
@@ -69,10 +69,15 @@ public function acquire(?Cancellation $cancellation = null): Lock
      */
     private function release(File $file): void
     {
+        $file->close();
+
         try {
-            $this->filesystem->deleteFile($this->fileName); // Delete file while holding the lock.
-            $file->close();
+            $this->filesystem->deleteFile($this->fileName);
         } catch (FilesystemException $exception) {
+            if (IS_WINDOWS) {
+                return; // Windows will fail to delete the file if another handle is open.
+            }
+
             throw new SyncException(
                 'Failed to unlock the mutex file: ' . $this->fileName,
                 previous: $exception,