Check pid watcher has not already been cancelled

amphp · Dec 13, 2024 · 187cdad · 187cdad
1 parent 1949d85
commit 187cdad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/Internal/Windows/Handle.php b/lib/Internal/Windows/Handle.php
@@ -41,7 +41,7 @@ public function __construct()
     /** @var Deferred[] */
     public $stdioDeferreds;
 
-    /** @var string */
+    /** @var string|null */
     public $childPidWatcher;
 
     /** @var string */

diff --git a/lib/Internal/Windows/SocketConnector.php b/lib/Internal/Windows/SocketConnector.php
@@ -366,8 +366,10 @@ public function onProcessConnectTimeout($watcher, Handle $handle)
 
         $handle->joinDeferred->fail($error);
 
-        Loop::cancel($handle->childPidWatcher);
-        $handle->pidDeferred->fail($error);
+        if ($handle->childPidWatcher !== null) {
+            Loop::cancel($handle->childPidWatcher);
+            $handle->pidDeferred->fail($error);
+        }
     }
 
     public function registerPendingProcess(Handle $handle)