adding Session Widget to pages: index + sessions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Apr 24, 2023
| date && date >= new Date() ? "Upcoming Session" : "Previous Session"; | ||
| --- | ||
|
|
||
| <div class="card border p-3 bg-light"> |
There was a problem hiding this comment.
Could you move all of this to be inline with the sessions.astro page?
I don't think this really needs to be its own component. I don't think we will have many use-cases to ever re-use it.
| </div> | ||
| </div> | ||
|
|
||
| <script is:inline src="https://cdn.jsdelivr.net/npm/[email protected]/moment.min.js" |
There was a problem hiding this comment.
Is moment.js still cool?
We can most likely use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/RelativeTimeFormat instead.
And just hide the element if the browser doesn't support that API.
|
We've recently changed the website a bit and I've included your proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to add a Session widget (last session), with a dynamic countdown (changes on refresh)
related to issues: