Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update okhttp to latest version #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

izaaz
Copy link
Contributor

@izaaz izaaz commented Mar 28, 2024

Updating okhttp to the latest version

Copy link
Contributor

@justin-fiedler justin-fiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but changing OkHttp sometimes causes issues. Need to look something up and get back to you.

@justin-fiedler justin-fiedler self-requested a review March 28, 2024 23:46
@@ -65,7 +65,7 @@ android {

dependencies {
implementation 'com.amplitude:analytics-connector:1.0.0'
implementation 'com.squareup.okhttp3:okhttp:4.2.2'
implementation 'com.squareup.okhttp3:okhttp:4.12.0'
Copy link
Contributor

@justin-fiedler justin-fiedler Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a heads up in case we start getting new support requests for Accessing hidden method Lcom/android/org/conscrypt/OpenSSLSocketImpl or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants