Skip to content

Commit

Permalink
Merge pull request #128 from amplitude/force-https-true
Browse files Browse the repository at this point in the history
Default forceHtttps to true
  • Loading branch information
blazzy authored Nov 21, 2017
2 parents 6e12116 + 1a33cf1 commit 74ba919
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default {
batchEvents: false,
eventUploadThreshold: 30,
eventUploadPeriodMillis: 30 * 1000, // 30s
forceHttps: false,
forceHttps: true,
includeGclid: false,
saveParamsReferrerOncePerSession: true,
deviceIdFromUrlParam: false,
Expand Down
1 change: 1 addition & 0 deletions test/amplitude-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,7 @@ describe('setVersionName', function() {
});

it('should send request', function() {
amplitude.options.forceHttps = false;
amplitude.logEvent('Event Type 1');
assert.lengthOf(server.requests, 1);
assert.equal(server.requests[0].url, 'http://api.amplitude.com/');
Expand Down
1 change: 1 addition & 0 deletions test/amplitude.js
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,7 @@ describe('setVersionName', function() {
});

it('should send request', function() {
amplitude.options.forceHttps = false;
amplitude.logEvent('Event Type 1');
assert.lengthOf(server.requests, 1);
assert.equal(server.requests[0].url, 'http://api.amplitude.com/');
Expand Down

0 comments on commit 74ba919

Please sign in to comment.