Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix OOM error when a bad api key is passed #210

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

izaaz
Copy link
Collaborator

@izaaz izaaz commented Aug 8, 2024

Summary

When the server returns a 400 because of a bad api key, we continuously retry without dropping the data. This fixes that issue

Fixes issue #208

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Izaaz for fixing it. LGTM. Nits: add a test for in memory response handler

@izaaz izaaz enabled auto-merge (squash) August 8, 2024 16:55
@izaaz izaaz disabled auto-merge August 8, 2024 16:56
@izaaz izaaz merged commit 8f1c047 into main Aug 8, 2024
4 checks passed
@izaaz izaaz deleted the AMP-106528/fix_bad_api_key_error branch August 8, 2024 23:36
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
## [1.17.1](v1.17.0...v1.17.1) (2024-08-09)

### Bug Fixes

* Fix OOM error when a bad api key is passed ([#210](#210)) ([8f1c047](8f1c047))
Copy link

github-actions bot commented Aug 9, 2024

🎉 This PR is included in version 1.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants