fix: set offline when receiving certain error responses (#212)

amplitude · Aug 19, 2024 · 056ccbf · 056ccbf
1 parent 0ef306e
commit 056ccbf
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/Sources/Amplitude/Utilities/HttpClient.swift b/Sources/Amplitude/Utilities/HttpClient.swift
@@ -37,10 +37,19 @@ class HttpClient {
             let request = try getRequest()
             let requestData = getRequestData(events: events)
 
-            sessionTask = session.uploadTask(with: request, from: requestData) { [callbackQueue] data, response, error in
+            sessionTask = session.uploadTask(with: request, from: requestData) { [callbackQueue, configuration] data, response, error in
                 callbackQueue.async {
-                    if error != nil {
-                        completion(.failure(error!))
+                    if let error = error {
+                        let nsError = error as NSError
+                        if nsError.domain == NSURLErrorDomain {
+                            switch nsError.code {
+                            case NSURLErrorCannotConnectToHost, NSURLErrorNetworkConnectionLost, NSURLErrorCannotFindHost, NSURLErrorAppTransportSecurityRequiresSecureConnection:
+                                configuration.offline = true
+                            default:
+                                break
+                            }
+                        }
+                        completion(.failure(error))
                     } else if let httpResponse = response as? HTTPURLResponse {
                         switch httpResponse.statusCode {
                         case 1..<300:

diff --git a/Tests/AmplitudeTests/Utilities/HttpClientTests.swift b/Tests/AmplitudeTests/Utilities/HttpClientTests.swift
@@ -86,4 +86,25 @@ final class HttpClientTests: XCTestCase {
         }
         _ = XCTWaiter.wait(for: [asyncExpectation], timeout: 5)
     }
+
+    func testUploadWithCannotConnectToHostError() {
+        let config = Configuration(apiKey: "fake", serverUrl: "http://localhost:3000", offline: false)
+        let httpClient = HttpClient(configuration: config, diagnostics: diagonostics)
+        let uploadExpectation = expectation(description: "Did Call Upload")
+        let event = BaseEvent(userId: "unit-test user", eventType: "unit-test event")
+
+        _ = httpClient.upload(events: "[\(event.toString())]") { result in
+            switch result {
+            case .success:
+                XCTFail("Expected failure")
+            case .failure(let error):
+                XCTAssertEqual((error as NSError).code, NSURLErrorCannotConnectToHost)
+            }
+
+            uploadExpectation.fulfill()
+        }
+
+        waitForExpectations(timeout: 5)
+        XCTAssertEqual(config.offline, true)
+    }
 }