feat: add client upload time

amplitude · Oct 18, 2023 · 22127d6 · 22127d6
1 parent 746d433
commit 22127d6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/Sources/Amplitude/Utilities/HttpClient.swift b/Sources/Amplitude/Utilities/HttpClient.swift
@@ -72,8 +72,9 @@ class HttpClient {
 
     func getRequestData(events: String) -> Data? {
         let apiKey = configuration.apiKey
+        let clientUploadTime: String = ISO8601DateFormatter().string(from: Date())
         var requestPayload = """
-            {"api_key":"\(apiKey)","events":\(events)
+            {"api_key":"\(apiKey)","client_upload_time":"\(clientUploadTime)","events":\(events)
             """
         if let minIdLength = configuration.minIdLength {
             requestPayload += """

diff --git a/Tests/AmplitudeTests/Utilities/HttpClientTests.swift b/Tests/AmplitudeTests/Utilities/HttpClientTests.swift
@@ -42,6 +42,23 @@ final class HttpClientTests: XCTestCase {
         }
     }
 
+    func testGetRequestData() {       
+        let httpClient = HttpClient(configuration: configuration)
+        let event = BaseEvent(userId: "unit-test user", eventType: "unit-test event")
+
+        let dateFormatter = ISO8601DateFormatter()
+        let currentDate = Date()
+        let expectedClientUploadTime = dateFormatter.string(from: currentDate)
+
+        let expectedRequestPayload = """
+            {"api_key":"testApiKey","client_upload_time":"\(expectedClientUploadTime)","events":[\(event.toString())]}
+            """.data(using: .utf8)
+
+        let result = httpClient.getRequestData(events: "[\(event.toString())]")
+
+        XCTAssertEqual(result, expectedRequestPayload)
+    }
+
     func testUploadWithInvalidApiKey() {
         // TODO: currently this test is sending request to real Amplitude host, update to mock for better stability
         let httpClient = HttpClient(configuration: configuration)