fix: ensure event data is sandboxed per app for all platforms #113
+116
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-fiedler
requested review from
izaaz,
Mercy811,
qingzhuozhen and
bgiori
qingzhuozhen
approved these changes
Feb 1, 2024
|
@bgiori added you incase there are any concerns on this affecting Experiment integration |
Thanks @qingzhuozhen, I meant this to be a draft PR for early feedback. In process of adding tests now. |
theolampert
reviewed
Feb 1, 2024
Mercy811
approved these changes
Feb 2, 2024
qingzhuozhen
approved these changes
Feb 2, 2024
theolampert
approved these changes
Feb 3, 2024
justin-fiedler
deleted the
AMP-92879-sandbox-storage-location-on-macos
branch
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-02-05) ### Bug Fixes * ensure event data is sandboxed per app for all platforms ([#113](#113)) ([72da9f8](72da9f8)) * should track coarse location by default ([#110](#110)) ([2aab265](2aab265)) ### Features * add privacy manifest for ios 17 ([#109](#109)) ([cf0ca47](cf0ca47))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
com.amplitude.AmpliTunes.Switch to- Removed until we can write migration logic (thanks @tcldr for calling out in Persistent Storage uses caches/document directory #104, Use Application Support Directory for Persistent Storage #105)applicationSupportDirectoryfor most app storage to follow storage best practicesiOS - App Sandbox On (always)
Create
amplitudedirectory in application specific/Library/Application Supportfile:///Users/justin/Library/Developer/CoreSimulator/Devices/AA0CFF70-35A4-4D85-AB9A-C27A8DBF94D7/data/Containers/Data/Application/06213CC5-0BE3-4822-BF6A-44C711467CB7/Library/Application%20Support/amplitude/amplitude-swift-identify-default_instance.events.indexmacOs - App Sandbox Off
Create
amplitude/<bundleId>directory in shared/Library/Application Supportfile:///Users/justin/Library/Application%20Support/amplitude/com.amplitude.Amplitude.AmplitudeSwiftUIExample/amplitude-swift-identify-default_instance.events.indexmacOs - App Sandbox On
Create
amplitudedirectory in application specific/Library/Containers/<bundleId>/.../Application Supportfile:///Users/justin/Library/Containers/com.amplitude.Amplitude.AmplitudeSwiftUIExample/Data/Library/Application%20Support/amplitude/amplitude-swift-identify-default_instance.events.indexTesting
To toggle app sandbox in XCode for macOS
Checklist