Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use extension safe APIs #231

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: Use extension safe APIs #231

merged 1 commit into from
Oct 1, 2024
+19 −10

Conversation

crleona
Copy link
Collaborator

@crleona crleona commented Sep 27, 2024

Summary

UIApplication.shared is not extension safe and will cause builds with APPLICATION_EXTENSION_API_ONLY to fail. This PR fixes access and adds APPLICATION_EXTENSION_API_ONLY to our build config so that our builds will fail as well.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@crleona crleona requested a review from a team September 27, 2024 20:09
@crleona crleona merged commit 4794f4e into main Oct 1, 2024
8 checks passed
@crleona crleona deleted the AMP-111098-fix-make-extension-safe branch October 1, 2024 21:50
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
@amplitude-sdk-bot
chore(release): 1.9.3 [skip ci]
3ac8de1 
## [1.9.3](v1.9.2...v1.9.3) (2024-10-01)

### Bug Fixes

* add autoreleasepool around sendNextEventFile ([#232](#232)) ([0ec1187](0ec1187))
* improve logging in httpclient ([#228](#228)) ([633deb5](633deb5))
* Use extension safe APIs ([#231](#231)) ([4794f4e](4794f4e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaaz izaaz izaaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crleona @izaaz